Skip to content

support query-plan-analysis on pdo prepared statements #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

support query-plan-analysis on pdo prepared statements #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f5b7b
added failling test for bug 385
clxmstaab May 27, 2022
fc63535
Merge branch 'main' into bug385
clxmstaab May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/rules/QueryPlanAnalyzerRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ public function testNotUsingIndex(): void
28,
$tip,
],
[
"Query is not using an index on table 'ada'.".$proposal,
56,
$tip,
],
]);
}
}
6 changes: 6 additions & 0 deletions tests/rules/data/query-plan-analyzer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,10 @@ public function writes(PDO $pdo, int $adaid): void
$pdo->query('REPLACE INTO `ada` SET email="test" WHERE adaid = '.$adaid);
$pdo->query('DELETE FROM `ada` WHERE adaid = '.$adaid);
}

public function bug385(PDO $pdo, string $email): void
{
$stmt = $pdo->query('SELECT * FROM `ada` WHERE email = ?');
$stmt->execute([$email]);
}
}