Skip to content

Conversation

@rhysrevans3
Copy link

Proposed changes for replacing variable object with bands from core spec #30

Comment on lines 500 to 538
"title": "Variable Object",
"type": "object",
"bands": {
"required": [
"dimensions"
"cube:dimensions_refs",
"cube:type"
],
"properties": {
"variable_type": {
"type": "string",
"enum": [
"data",
"auxiliary"
]
},
"description": {
"$ref": "#/definitions/description"
},
"dimensions": {
"type": "array",
"items": {
"type": "string"
}
},
"values": {
"type": "array",
"minItems": 1
},
"extent": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": {
"type": [
"string",
"number",
"null"
]
}
},
"unit": {
"$ref": "#/definitions/unit"
},
"nodata": {
"$ref": "#/definitions/nodata"
},
"data_type": {
"$ref": "#/definitions/data_type"
}
}
"$ref": "https://schemas.stacspec.org/v1.1.0/item-spec/json-schema/bands.json#bands"
Copy link
Author

@rhysrevans3 rhysrevans3 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this is the correct way to reference the core bands spec and require the cube:dimension_refs and cube:type fields

@m-mohr m-mohr linked an issue Oct 22, 2025 that may be closed by this pull request
@m-mohr m-mohr requested review from Copilot and m-mohr and removed request for Copilot October 22, 2025 21:54
Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer some more justification than what is in #30 before making such a drastic breaking change. As of now, I'm -1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal for replacing variable object with bands

2 participants