-
Notifications
You must be signed in to change notification settings - Fork 6
Replacing cube:variable with bands #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "title": "Variable Object", | ||
| "type": "object", | ||
| "bands": { | ||
| "required": [ | ||
| "dimensions" | ||
| "cube:dimensions_refs", | ||
| "cube:type" | ||
| ], | ||
| "properties": { | ||
| "variable_type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "data", | ||
| "auxiliary" | ||
| ] | ||
| }, | ||
| "description": { | ||
| "$ref": "#/definitions/description" | ||
| }, | ||
| "dimensions": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "values": { | ||
| "type": "array", | ||
| "minItems": 1 | ||
| }, | ||
| "extent": { | ||
| "type": "array", | ||
| "minItems": 2, | ||
| "maxItems": 2, | ||
| "items": { | ||
| "type": [ | ||
| "string", | ||
| "number", | ||
| "null" | ||
| ] | ||
| } | ||
| }, | ||
| "unit": { | ||
| "$ref": "#/definitions/unit" | ||
| }, | ||
| "nodata": { | ||
| "$ref": "#/definitions/nodata" | ||
| }, | ||
| "data_type": { | ||
| "$ref": "#/definitions/data_type" | ||
| } | ||
| } | ||
| "$ref": "https://schemas.stacspec.org/v1.1.0/item-spec/json-schema/bands.json#bands" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is the correct way to reference the core bands spec and require the cube:dimension_refs and cube:type fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer some more justification than what is in #30 before making such a drastic breaking change. As of now, I'm -1.
Proposed changes for replacing variable object with bands from core spec #30