Create Common opensearch/ elasticsearch core package

[jonhealy1]

Related Issue(s):

• Add opensearch support #167

Description:
Create a common opensearch/ elasticsearch core package. Create separate stac-fastapi.opensearch and stac-fastapi.elasticsearch packages.

PR Checklist:

• Code is formatted and linted (run pre-commit run --all-files)
• Tests pass (run make test)
• Documentation has been updated to reflect changes, if applicable
• Changes are added to the changelog

[jamesfisher-geo]

Looks great. After #187 is merged, the only backend-specific code will be in the *_config.py and the *_database_logic.py files. Everything else can be contained in the core module, right?

[jonhealy1]

Looks great. After #187 is merged, the only backend-specific code will be in the *_config.py and the *_database_logic.py files. Everything else can be contained in the core module, right?

I think I have moved everything around properly. I am not a git expert so I didn't know the easiest or best way to do this. Have a look. I think the main thing we need to do is update the update_collection method in opensearch/database_logic.py. I haven't updated the Makefile yet either ....

[jonhealy1]

If you want we can merge your branch into main before we merge this. Up to you. Another thing to think about too is how the tests are duplicated right now. Maybe we want a separate package for the tests?

[jamesfisher-geo]

Looks great. After #187 is merged, the only backend-specific code will be in the *_config.py and the *_database_logic.py files. Everything else can be contained in the core module, right?

I think I have moved everything around properly. I am not a git expert so I didn't know the easiest or best way to do this. Have a look. I think the main thing we need to do is update the update_collection method in opensearch/database_logic.py. I haven't updated the Makefile yet either ....

Merged those changes into the add-opensearch branch. I included a couple changes to the makefile to run tests on one or both backends

[jamesfisher-geo]

If you want we can merge your branch into main before we merge this. Up to you. Another thing to think about too is how the tests are duplicated right now. Maybe we want a separate package for the tests?

Cool, I think #188 is ready go. I will let you take a look and commit to main. Right now they are both passing the same set of tests. All the ES/OS calls are wrapped in the database_logic methods, so it seems to work fine for both.

[jonhealy1]

@jamesfisher-gis Hi. I think this is ready for review now.

[jonhealy1]

@gadomski @philvarner Adding you guys if you have time to review or even share your thoughts.

[jonhealy1]

This is actually a really long pr but the vast majority of it is only moving code around.

[jamesfisher-geo]

@jamesfisher-gis Hi. I think this is ready for review now.

Sounds good. Will review tomorrow eve

[jamesfisher-geo]

Hey @jonhealy1 this looks great.