Support extensions defining top-level properties on collections #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that all 'core' stac properties are populated w/ default values if omitted by client during collection creation
nkleinbaer
commented
Feb 5, 2024
There was a problem hiding this comment.
Initially I thought it would be necessary to use stac_pydantic.Collection, which disallows empty strings for certain props ... that proved not to be necessary, but I left these changes hanging around. 3c7b581 reverts back to the original defaults.
jonhealy1
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, extensions that define additional top-level properties on collection objects (e.g. item-assets) are effectively unusable because the
CollectionSerializer.db_to_staconly allows the 'core' properties to be passed through. This PR changes that to allow arbitrary additional props.That method also includes code to populate the 'core' properties with default values if they are not present. At one point while working on this I had deleted that code and noticed that doing so did not break any tests. So I added
test_collection_defaultsto ensure that any changes to that behavior will be caught going forward.PR Checklist:
pre-commit run --all-files)make test)- [ ] Documentation has been updated to reflect changes, if applicable