Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TLS CA cert path used in REQUESTS_CA_BUNDLE #529

Closed
wants to merge 4 commits into from

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Nov 4, 2024

Description

Fix the TLS CA cert path used in the environment variable REQUESTS_CA_BUNDLE.

The prior implementation always used the static path /stackable/secrets/tls/ca.crt which is not valid for web PKI or SecretClasses other than tls.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@siegfriedweber siegfriedweber self-assigned this Nov 4, 2024
@siegfriedweber siegfriedweber force-pushed the fix/tls_ca_cert_mount_path branch from 38069ad to 7249f91 Compare November 4, 2024 19:47
@siegfriedweber siegfriedweber requested a review from a team November 5, 2024 12:21
@siegfriedweber siegfriedweber marked this pull request as ready for review November 5, 2024 12:21
@siegfriedweber
Copy link
Member Author

closed in favor of #530

@siegfriedweber siegfriedweber deleted the fix/tls_ca_cert_mount_path branch November 6, 2024 08:37
@siegfriedweber siegfriedweber removed the request for review from a team November 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant