Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache sysinfo data, and only query for the data we actually use #20

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Dec 16, 2024

Description

Fixes #19. There's still room for improvement, but on my desktop this takes us from ~50MiB on startup and ~95MiB steady state, to ~8MiB steady state.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback
No tasks being tracked yet.

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr nightkr self-assigned this Dec 16, 2024
@nightkr nightkr requested review from razvan and a team December 16, 2024 12:19
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, weird api but it works

@nightkr nightkr added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 3a2e8e9 Dec 16, 2024
9 of 10 checks passed
@nightkr nightkr deleted the feature/limit-sysinfo branch December 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High memory usage
2 participants