Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: expand end-to-end-security demo documentation #128

Merged
merged 7 commits into from
Nov 15, 2024
Merged

docs: expand end-to-end-security demo documentation #128

merged 7 commits into from
Nov 15, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Nov 14, 2024

Added some written instructions to the end-to-end-security demo documentation based on the end-to-end-security demo recording

@xeniape xeniape self-assigned this Nov 14, 2024
@NickLarsenNZ NickLarsenNZ mentioned this pull request Nov 15, 2024
Closed
NickLarsenNZ
NickLarsenNZ requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of changes.

docs/modules/demos/pages/end-to-end-security.adoc Outdated Show resolved Hide resolved
docs/modules/demos/pages/end-to-end-security.adoc Outdated Show resolved Hide resolved
docs/modules/demos/pages/end-to-end-security.adoc Show resolved Hide resolved
xeniape and others added 4 commits November 15, 2024 11:23
@xeniape @NickLarsenNZ
Update docs/modules/demos/pages/end-to-end-security.adoc
34555a6 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@xeniape @NickLarsenNZ
Update docs/modules/demos/pages/end-to-end-security.adoc
9a8867b 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@xeniape @NickLarsenNZ
Update docs/modules/demos/pages/end-to-end-security.adoc
b38272c 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@xeniape
Merge branch 'main' into docs/expand-end-to-end-security-demo-documen…
be78111 
…tation
@NickLarsenNZ NickLarsenNZ self-requested a review November 15, 2024 10:48
NickLarsenNZ
NickLarsenNZ approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 8acb9be Nov 15, 2024
2 checks passed
@xeniape xeniape deleted the docs/expand-end-to-end-security-demo-documentation branch November 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@xeniape xeniape

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeniape @NickLarsenNZ