Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename clusterOperation flag "reconcilePaused" to "reconciliationPaused" #462

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

siegfriedweber
Copy link
Member

Rename clusterOperation flag "reconcilePaused" to "reconciliationPaused"

This change should be backported to 23.7 and 23.4.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 1543150
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/6515664e5253120008ec19d4
😎 Deploy Preview https://deploy-preview-462--stackable-docs.netlify.app/home/nightly/concepts/operations/cluster_operations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nightkr
Copy link
Member

nightkr commented Sep 28, 2023

Is this an actual breaking change or a case of the docs mismatching the implementation?

@siegfriedweber
Copy link
Member Author

Is this an actual breaking change or a case of the docs mismatching the implementation?

The documentation was incorrect. The implementation always used reconciliationPaused.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this only fixes the docs. Do you take care of back-porting this?

@siegfriedweber siegfriedweber added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit b6a3c7a Sep 28, 2023
4 checks passed
@siegfriedweber siegfriedweber deleted the fix-reconciliation-paused-flag branch September 28, 2023 11:57
@siegfriedweber siegfriedweber changed the title Rename clusterOperation flag "reconcilePaused" to "reconciliationPaused" Fix: Rename clusterOperation flag "reconcilePaused" to "reconciliationPaused" Sep 28, 2023
@siegfriedweber
Copy link
Member Author

LGTM as this only fixes the docs. Do you take care of back-porting this?

backported to 23.7 and 23.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants