-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(code-style-guide): Add comment rules #668
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Do we need a decision for this? (e.g. I personally prefer 120 chars, but could live with 100)
We can open a decision for this, but tbh, I wouldn't push beyond 100 characters. Rust's Beyond that point, it gets hard to read. It is well known at this point, that you should avoid using long lines of continuous text to easy the process of reading it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. I think we should put it on the decision board, just so that people could veto - but I don't expect any veto
Moving this into voting. Options are:
|
"line-widths between 80 and 100" - I was not aware that Rust is so close to FORTRAN :-) |
I should clarify: Just for the comments, code is usually formatted at 100 and above. But yes, developers like their narrow comments :) |
I just like narrow for reviewing side by side. Otherwise I like 100. No action needed, just sharing. |
Does the max line length apply to code too? |
No, we are only talking about comments. Rust code is formatted by |
There seems to be no further activity. I will mark this decision as accepted tomorrow and move it to "Done" afterwards. |
Marking as accepted. |
This adds a bunch of rules regarding Rust comments.
Direct link