Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuring cluster domain guide #673

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Add configuring cluster domain guide #673

merged 10 commits into from
Oct 23, 2024

Conversation

maltesander
Copy link
Member

No description provided.

@maltesander maltesander self-assigned this Oct 17, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit e8c8918
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/6718f1b63e788a000829d85d
😎 Deploy Preview https://deploy-preview-673--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maltesander maltesander mentioned this pull request Oct 17, 2024
Closed
2 tasks
sbernauer
sbernauer requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

modules/guides/pages/cluster-domain.adoc Outdated Show resolved Hide resolved
modules/guides/pages/cluster-domain.adoc Outdated Show resolved Hide resolved
modules/guides/pages/cluster-domain.adoc Outdated Show resolved Hide resolved
modules/guides/pages/cluster-domain.adoc Outdated Show resolved Hide resolved
modules/guides/pages/cluster-domain.adoc Outdated Show resolved Hide resolved
modules/guides/pages/cluster-domain.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/kubernetes/index.adoc Outdated Show resolved Hide resolved
maltesander and others added 2 commits October 18, 2024 09:30
@maltesander @sbernauer
Apply suggestions from code review
884bc37 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander
rename to kubernetes-cluster-domain.adoc
48798fb
@maltesander maltesander marked this pull request as ready for review October 18, 2024 07:34
sbernauer
sbernauer previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@maltesander maltesander enabled auto-merge October 18, 2024 07:47
sbernauer
sbernauer previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

modules/guides/pages/kubernetes-cluster-domain.adoc Outdated Show resolved Hide resolved
modules/guides/pages/kubernetes-cluster-domain.adoc Show resolved Hide resolved
@maltesander @sbernauer
Update modules/guides/pages/kubernetes-cluster-domain.adoc
e8c8918 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander maltesander added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit c393f5c Oct 23, 2024
6 of 7 checks passed
@maltesander maltesander deleted the add-cluster-domain-docs branch October 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @sbernauer