Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playbook references #687

Closed
wants to merge 1 commit into from
Closed

Conversation

NickLarsenNZ
Copy link
Member

Thanks @xeniape and @razvan for spotting this.

Relevant Slack discussion.

* Add release branches to the playbooks for release 24.11

* trigger checks again
@NickLarsenNZ NickLarsenNZ self-assigned this Nov 29, 2024
@NickLarsenNZ NickLarsenNZ changed the base branch from main to release/24.11 November 29, 2024 16:23
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for stackable-docs failed.

Name Link
🔨 Latest commit 764c633
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/6749ea6ceb085c0008624044

@NickLarsenNZ NickLarsenNZ requested a review from a team November 29, 2024 16:24
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -26,6 +26,7 @@ content:
- url: .
branches:
- HEAD
- release/24.11
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the merge. This might be wrong.

Previous branches don't include themselves as they are covered by HEAD (even though the site is deployed from main).

@NickLarsenNZ
Copy link
Member Author

Closing this, as it doesn't seem to be the fix

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Dec 3, 2024

The link to https://docs.stackable.tech/home/24.11/concepts/overrides/ is currently invalid, and only accessible via https://docs.stackable.tech/home/stable/concepts/overrides/. After 25.3, those links will work again, but be broken in the same way for 25.3.

stable is set here: https://github.com/stackabletech/documentation/blob/8b307104cc19f3b75c2ed0426794f10d56f4a3d6/antora-playbook.yml#L20C27-L20C33, maybe there is some way to allow the latest version to also be allowed (rewritten or redirected).


Edit:

latest_version_segment_strategy: redirect:to
should be allowing the redirect from latest xx.xx -> stable. 🤷

@Techassi
Copy link
Member

Techassi commented Dec 4, 2024

I researched why latest_version_segment_strategy doesn't redirect like we expect. The behaviour of this option is influenced by the redirect_facility option. I'll have to do further research to determine if there is a combination of options which works for our deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants