Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graceful shutdown #486

Merged
merged 14 commits into from
Nov 16, 2023
Merged

Support graceful shutdown #486

merged 14 commits into from
Nov 16, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Nov 13, 2023 •
edited by adwk67
Loading

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@maltesander maltesander changed the title SupportFeat/graceful shutdown Support graceful shutdown Nov 13, 2023
@maltesander maltesander requested a review from a team November 13, 2023 11:01
@maltesander maltesander self-assigned this Nov 13, 2023
@maltesander maltesander mentioned this pull request Nov 13, 2023
Closed
@maltesander maltesander marked this pull request as ready for review November 13, 2023 13:06
@adwk67 adwk67 requested review from adwk67 and removed request for a team November 15, 2023 09:00
adwk67
adwk67 reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: just a couple of comments/nits about making it clearer in the docs about what is happenening where.

docs/modules/druid/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
rust/operator-binary/src/operations/graceful_shutdown.rs Show resolved Hide resolved
docs/modules/druid/pages/usage-guide/operations/graceful-shutdown.adoc Show resolved Hide resolved
@maltesander maltesander requested a review from adwk67 November 15, 2023 13:29
adwk67
adwk67 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/modules/druid/pages/usage-guide/operations/graceful-shutdown.adoc Show resolved Hide resolved
rust/operator-binary/src/operations/graceful_shutdown.rs Show resolved Hide resolved
@maltesander
Copy link
Member Author

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/124/

@maltesander
Copy link
Member Author

another try on azure: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/125/

@maltesander maltesander added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 19d98af Nov 16, 2023
29 checks passed
@maltesander maltesander deleted the feat/graceful-shutdown branch November 16, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@maltesander maltesander

Labels
release/23.11.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @adwk67