Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions for SDP 24.7 #583

Merged
merged 21 commits into from
Jul 23, 2024
Merged

Update supported versions for SDP 24.7 #583

merged 21 commits into from
Jul 23, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Jul 1, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@lfrancke lfrancke self-assigned this Jul 1, 2024
@lfrancke lfrancke marked this pull request as ready for review July 11, 2024 09:58
@maltesander maltesander self-requested a review July 11, 2024 09:58
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things. LGTM otherwise. Will start the test once built is done.

CHANGELOG.md Outdated Show resolved Hide resolved
tests/templates/kuttl/ldap/13-install-druid.yaml.j2 Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lfrancke lfrancke requested a review from maltesander July 11, 2024 10:15
CHANGELOG.md Outdated Show resolved Hide resolved
@maltesander
Copy link
Member

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked the product versions against the spreadsheet

@lfrancke lfrancke added this pull request to the merge queue Jul 23, 2024
Copy link
Contributor

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked if no test was forgotten and on typos, tests have been done by the author.

LGTM! Thank you.

Merged via the queue into main with commit 26bcb6d Jul 23, 2024
31 checks passed
@lfrancke lfrancke deleted the feat/24.7 branch July 23, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants