Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stackabletctl): Support OCI registries #344

Merged
merged 23 commits into from
Jan 27, 2025
Merged

feat(stackabletctl): Support OCI registries #344

merged 23 commits into from
Jan 27, 2025

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 17, 2024 •
edited
Loading

Description

This PR covers the following:

  • addition of the option --chart-source that enables charts to be pulled either from an OCI registry (the default) or a Nexus repository
  • retrieves tags from Harbor or Nexus for operator list and describe commands

Caution

Do not merge & release before Jan 2025 as this will affect the kuttl tests.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@adwk67 adwk67 self-assigned this Dec 17, 2024
@adwk67 adwk67 marked this pull request as ready for review December 19, 2024 10:24
@adwk67 adwk67 requested a review from a team January 7, 2025 08:53
@Techassi Techassi self-requested a review January 7, 2025 08:57
Techassi
Techassi requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that feature! I left a few comments and suggestions.

rust/stackablectl/src/cli/mod.rs Show resolved Hide resolved
rust/stackablectl/src/cmds/demo.rs Outdated Show resolved Hide resolved
rust/stackablectl/src/cli/mod.rs Outdated Show resolved Hide resolved
rust/stackable-cockpit/src/oci.rs Show resolved Hide resolved
rust/stackablectl/src/cmds/operator.rs Outdated Show resolved Hide resolved
rust/stackable-cockpit/src/oci.rs Outdated Show resolved Hide resolved
rust/stackable-cockpit/src/oci.rs Outdated Show resolved Hide resolved
rust/stackable-cockpit/src/oci.rs Outdated Show resolved Hide resolved
rust/stackable-cockpit/src/platform/manifests.rs Show resolved Hide resolved
rust/stackable-cockpit/src/oci.rs Outdated Show resolved Hide resolved
@adwk67 adwk67 requested a review from Techassi January 24, 2025 13:27
@sbernauer sbernauer changed the title feat: Support OCI registries feat(stackabletctl): Support OCI registries Jan 27, 2025
@adwk67 adwk67 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 01632e6 Jan 27, 2025
35 checks passed
@adwk67 adwk67 deleted the feat/install-from-registry branch January 27, 2025 12:58
@Techassi Techassi mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@adwk67 adwk67

Labels
None yet
Projects
Stackable Engineering
Status: Development: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adwk67 @Techassi