Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenID Connect support #501

Merged
merged 53 commits into from
Feb 26, 2024
Merged

OpenID Connect support #501

merged 53 commits into from
Feb 26, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 17, 2023 •
edited by lfrancke
Loading

Description

Add OpenID Connect support

Closes #473

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

maltesander and others added 20 commits October 24, 2023 18:01
github-actions[bot]
github-actions bot reviewed Nov 17, 2023
View reviewed changes
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer mentioned this pull request Nov 17, 2023
Open
@siegfriedweber siegfriedweber self-assigned this Feb 15, 2024
@siegfriedweber
Copy link
Member

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/114/

@siegfriedweber siegfriedweber marked this pull request as ready for review February 15, 2024 13:14
@siegfriedweber siegfriedweber requested a review from a team February 15, 2024 13:21
@adwk67 adwk67 requested review from adwk67 and removed request for a team February 15, 2024 13:40
adwk67
adwk67 previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one tiny nit.

rust/operator-binary/src/authentication/oidc/mod.rs Outdated Show resolved Hide resolved
tests/templates/kuttl/authentication/create-trino-cluster.yaml.j2 Show resolved Hide resolved
siegfriedweber and others added 2 commits February 26, 2024 08:06
@siegfriedweber @adwk67
Fix comment
845d196 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@siegfriedweber
Merge branch 'main' into feature/support-oauth2
4372a30
@siegfriedweber siegfriedweber added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 7439cde Feb 26, 2024
30 checks passed
@siegfriedweber siegfriedweber deleted the feature/support-oauth2 branch February 26, 2024 13:11
@lfrancke lfrancke added release/24.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 5, 2024
@lfrancke
Copy link
Member

lfrancke commented Mar 5, 2024

Could you please link the documentation here?

@siegfriedweber
Copy link
Member

https://docs.stackable.tech/home/nightly/trino/usage-guide/security#_oauth2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@adwk67 adwk67 adwk67 approved these changes

Assignees

@adwk67 adwk67

@siegfriedweber siegfriedweber

Labels
release/24.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenID Connect support
7 participants
@sbernauer @fhennig @siegfriedweber @lfrancke @adwk67 @maltesander @razvan