Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support PodDisruptionBudgets #730

Merged
merged 7 commits into from
Sep 27, 2023
Merged

feat: Support PodDisruptionBudgets #730

merged 7 commits into from
Sep 27, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 27, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer mentioned this pull request Sep 27, 2023
Closed
@sbernauer sbernauer self-assigned this Sep 27, 2023
@sbernauer sbernauer mentioned this pull request Sep 27, 2023
Closed
@maltesander maltesander self-requested a review September 27, 2023 10:38
maltesander
maltesander requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, LGTM otherwise! (crds need to be regenerated)

docs/modules/zookeeper/pages/usage_guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/zookeeper/pages/usage_guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
rust/operator-binary/src/operations/pdb.rs Outdated Show resolved Hide resolved
sbernauer and others added 2 commits September 27, 2023 14:04
@sbernauer
fix error message
ec02f63
@sbernauer @maltesander
Apply suggestions from code review
9406191 
Co-authored-by: Malte Sander <contact@maltesander.com>
maltesander
maltesander approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit b9eec48 Sep 27, 2023
29 checks passed
@sbernauer sbernauer deleted the feat/support-pdb-2 branch September 27, 2023 12:58
@fhennig
Copy link
Contributor

fhennig commented Sep 27, 2023

@sbernauer check the checkmarks in the Author list ;) follow the process!

@sbernauer
Copy link
Member Author

done :)

@maltesander
Copy link
Member

@fhennig is this the ticket police ;) ?

@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
release/2023-11 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbernauer @fhennig @maltesander @lfrancke