rearrange magnum config.yml #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
reviewed
Jul 20, 2023
| @@ -61,7 +61,11 @@ ca_file = {{ openstack_cacert }} | |||
|
|
|||
| [nova_client] | |||
| region_name = {{ openstack_region_name }} | |||
| {% if magnum_cluster_api_driver_enabled is defined %} | |||
| endpoint_type = publicURL | |||
There was a problem hiding this comment.
What is it that actually needs this? The k8s management cluster? I expect this requirement isn't strict, more about how we deploy it. In which case it might be better as documentation and in our own s-k-c config?
There was a problem hiding this comment.
@markgoddard copy and paste from the magnum docs but:
This is used to generate the application credential config injected into the tenant Kubernetes clusters, such that it is usable from within an OpenStack project, so you can't use the "internal API" end point here.
markgoddard
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fact determining whether the kubeconfig should be copied into the correct location, as well as the section of magnum.conf telling the capi driver where to find the kubeconfig, was being set after config.json and magnum.conf, resulting in misconfiguration.
Also magnum.conf is modified to make nova_client use the public url if the capi driver is enabled. This is needed to generate the application credential config injected into the tenant Kubernetes clusters