Support exposing prometheus_server externally #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need to use a proxy, or some other means, to connect to Prometheus. This is disabled by default and can be enabled by setting enable_prometheus_server_external to true. Change-Id: Ia0af044ff436c2a204b357750a16ff49fcdfec45 (cherry picked from commit 37c2ab2)
mnasiadka
approved these changes
Nov 13, 2023
markgoddard
suggested changes
Nov 13, 2023
| @@ -4,6 +4,9 @@ datasources: | |||
| - name: Prometheus | |||
| type: prometheus | |||
| access: proxy | |||
| basicAuth: true | |||
| basicAuthPassword: "{{ prometheus_grafana_password }}" | |||
There was a problem hiding this comment.
It's not ideal adding a new password to an existing release - on first deployment this is going to change passwords.yml and require being committed to the kayobe config. It could easily be missed, then regenerated by someone else.
There was a problem hiding this comment.
We should definitely merge this as-is into Z+A, but perhaps for Yoga the basic auth part should be opt-in?
There was a problem hiding this comment.
making basic auth opt in makes this feature pretty complicated to backport and it is diverging from upstream.
I'm not seeing much value added backporting it to yoga in that form - especially that we're in the upgrade phase to antelope anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to use a proxy, or some other means, to connect to Prometheus. This is disabled by default and can be enabled by setting enable_prometheus_server_external to true.
Change-Id: Ia0af044ff436c2a204b357750a16ff49fcdfec45 (cherry picked from commit 37c2ab2)
Conflicts:
removed vars for 41a9402