Fail to build on warnings #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
commented
Mar 2, 2023
markgoddard
commented
- CI: Only test default deployment.yaml in forks
- Warnings are errors
- CI: Add flags to deployment.yaml to avoid sphinx errors
For concrete instances of the admin guide we don't need to test all permutations, only the actual config.
|
Unsure if it's a good idea because it will affect all client admin guides. |
|
Shall we find out? I think it's worth doing. |
oneswig
approved these changes
Aug 15, 2024
|
Let's check that it still passes. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.