Skip to content

Conversation

grzegorzkoper
Copy link

No description provided.

@grzegorzkoper grzegorzkoper requested a review from a team as a code owner August 19, 2025 12:00
@grzegorzkoper grzegorzkoper requested a review from bbezak August 19, 2025 12:01
libnl3-devel libtool numactl-devel systemd-devel \
kernel-rpm-macros glibc-devel pciutils gcc valgrind-devel \
iptables-devel bison libdb-devel elfutils-devel \
tcsh binutils-devel flex gcc-gfortran python3-Cython \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gcc-gfortran really required?

dnf makecache && \
dnf install -y doca-ofed-userspace && \
dnf install -y --disablerepo=doca doca-kernel-* && \
dnf clean all No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line

DIB_RELEASE: "jammy"
DIB_CLOUD_INIT_DATASOURCES: "ConfigDrive"

# Rocky Linux 9 with Doca Ofed enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOCA OFED

DIB_CONTAINERFILE_RUNTIME: docker
YUM: dnf
DIB_CLOUD_INIT_DATASOURCES: "OpenStack, ConfigDrive"
DIB_RELEASE: "9.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think various tests in DIB expect DIB_RELEASE to be just the major version?

RUN systemd-machine-id-setup

# Install base build dependencies required by DOCA OFED
RUN dnf config-manager --set-enabled appstream crb && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these into a DIB element? Leaving all packages in the image is a security anti-pattern - at least let's remove them as a final step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants