Skip to content

Conversation

m-bull
Copy link
Contributor

@m-bull m-bull commented Sep 22, 2025

The Kayobe monitoring group, not the contollers group, is mapped to the Kolla-Ansible monitoring group by default.

The Kayobe monitoring group, not the contollers group, is mapped to the Kolla-Ansible monitoring group by default.
@m-bull m-bull requested a review from a team as a code owner September 22, 2025 10:13
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a documentation fix within a commented-out example in etc/kayobe/kolla.yml. The change corrects the default group mapping for monitoring services from controllers to monitoring under kolla_overcloud_inventory_top_level_group_map. This aligns the example with the intended default behavior, improving configuration clarity for users. The change is correct and I have no further feedback.

@MoteHue
Copy link
Contributor

MoteHue commented Sep 22, 2025

Should we change the comment to just link to the defaults instead?

The network group is no longer the controllers too, and there's now a compute-vgpu group we don't mention at all

@m-bull
Copy link
Contributor Author

m-bull commented Sep 22, 2025

I guess we'd have to remember to update the link each release, but a grep -r <previous-release> should catch it - we have to do that in a few places, so seems like a reasonable tradeoff to me.

@Alex-Welsh
Copy link
Member

I guess we'd have to remember to update the link each release, but a grep -r <previous-release> should catch it - we have to do that in a few places, so seems like a reasonable tradeoff to me.

We've got NOTE(upgrade): which we use for stuff like that, as a thing to search for and update each release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants