-
Notifications
You must be signed in to change notification settings - Fork 23
Fix top_level_group_map comment #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
The Kayobe monitoring group, not the contollers group, is mapped to the Kolla-Ansible monitoring group by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a documentation fix within a commented-out example in etc/kayobe/kolla.yml
. The change corrects the default group mapping for monitoring
services from controllers
to monitoring
under kolla_overcloud_inventory_top_level_group_map
. This aligns the example with the intended default behavior, improving configuration clarity for users. The change is correct and I have no further feedback.
Should we change the comment to just link to the defaults instead? The network group is no longer the controllers too, and there's now a compute-vgpu group we don't mention at all |
I guess we'd have to remember to update the link each release, but a |
We've got |
The Kayobe monitoring group, not the contollers group, is mapped to the Kolla-Ansible monitoring group by default.