ovn chassis priority playbook: Fix gateway chassis prefix stripping #1928
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue in an Ansible playbook's shell script where gateway chassis prefixes were not being stripped correctly when using a '-' delimiter. The change to use sed correctly addresses this. I have provided one suggestion to further improve the implementation by refactoring the loop to use shell parameter expansion. This would make the script more robust against potential special characters in variable names and more efficient by avoiding the creation of multiple subprocesses in a loop.
|
thx @grzegorzkoper for testing and finding bug |
mnasiadka
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on some environment gateway chassis is delimited with "-" instead of "_" (maybe from older ovn?) - take into account both options:
`
(ovn-nb-db)[root@controller42 /]# ovn-nbctl --no-leader-only lrp-get-gateway-chassis lrp-c8821294-a9e7-4b95-a7fc-5ed2bb947ab2
lrp-c8821294-a9e7-4b95-a7fc-5ed2bb947ab2-node2 3
lrp-c8821294-a9e7-4b95-a7fc-5ed2bb947ab2-node0 2
lrp-c8821294-a9e7-4b95-a7fc-5ed2bb947ab2-node1 1
(ovn-nb-db)[root@controller42 /]# ovn-nbctl --no-leader-only lrp-get-gateway-chassis lrp-fb5d5639-f1e9-4ae7-8cdf-e9fa0c587826
lrp-fb5d5639-f1e9-4ae7-8cdf-e9fa0c587826_node0 3
lrp-fb5d5639-f1e9-4ae7-8cdf-e9fa0c587826_node1 2
lrp-fb5d5639-f1e9-4ae7-8cdf-e9fa0c587826_node2 1
`