-
Notifications
You must be signed in to change notification settings - Fork 120
fix issues with propagating server and transport on telemetry #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with propagating server name and transport type to telemetry middleware by ensuring the computed values are used instead of the raw flag values.
- Modifies server name computation to extract from image metadata when name flag is empty
- Updates middleware configuration to use computed serverName and transportType parameters
- Adds comprehensive test coverage for telemetry parameter computation logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
cmd/thv/app/run_flags.go | Fixes telemetry middleware configuration by computing server name from image metadata and using computed values for middleware setup |
cmd/thv/app/run_flags_test.go | Adds test cases to validate server name extraction logic and transport type computation for telemetry middleware |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1973 +/- ##
==========================================
+ Coverage 47.93% 47.94% +0.01%
==========================================
Files 233 233
Lines 29172 29176 +4
==========================================
+ Hits 13983 13988 +5
+ Misses 14162 14152 -10
- Partials 1027 1036 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51d6163
to
4275ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the fix is working with my test cases.
Closes: #1898