Add remote MCP authentication documentation #1981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds detailed documentation about how ToolHive handles remote MCP server authentication, including compliance with various RFCs and the MCP authorization specification. The documentation covers: - Specification compliance (RFC 9728, RFC 8414, RFC 7591) - Authentication flow and discovery priority chain - Well-known endpoint discovery for issuer mismatch handling - Dynamic client registration - Security features and configuration options - Implementation details and key components This documentation helps developers understand the authentication architecture and serves as a reference for the implementation that was fixed in PR #1980.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
==========================================
- Coverage 47.31% 47.30% -0.02%
==========================================
Files 233 233
Lines 28649 28649
==========================================
- Hits 13555 13552 -3
- Misses 14083 14085 +2
- Partials 1011 1012 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive documentation for ToolHive's remote MCP server authentication implementation, providing detailed analysis of RFC compliance and authentication flows.
- Documents compliance with multiple RFCs including RFC 9728, RFC 8414, RFC 7591, and OAuth 2.1 PKCE
- Includes detailed authentication flow diagrams and discovery priority chains
- Provides configuration examples and implementation details for OAuth-based authentication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JAORMX
changed the title
yrobla
reviewed
Sep 29, 2025
|
@yrobla this is more of developer documentation. I can try to make it less bullet-y though 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive documentation about ToolHive's remote MCP server authentication implementation, detailing compliance with various RFCs and the MCP authorization specification.
What's Added
A new documentation file
docs/remote-mcp-authentication.mdthat covers:Specification Compliance
Authentication Details
Configuration & Implementation
Context
This documentation serves as a reference for the authentication architecture and complements the implementation fixes in PR #1980. It helps developers understand how ToolHive handles complex OAuth scenarios where the issuer differs from the server URL.
Testing
Related to #1957 and PR #1980