Add secrets management support to ToolHive MCP server #2006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements comprehensive secrets management functionality for the ToolHive MCP server, enabling users to manage secrets and pass them to MCP servers through the MCP interface.
Changes
New MCP Tools
list_secrets
- Lists all available secrets from the ToolHive secrets store with descriptionsset_secret
- Sets secrets by reading values from file paths (file-based input only for security)Enhanced
run_server
Toolsecrets
parameter with structuredSecretMapping
objects"secret_name,target=ENV_VAR_NAME"
)Implementation Details
Files Added/Modified
pkg/mcp/server/list_secrets.go
- List secrets tool implementationpkg/mcp/server/set_secret.go
- Set secret tool with validationpkg/mcp/server/run_server.go
- Enhanced with SecretMapping and prepareSecretspkg/mcp/server/handler.go
- Added configProvider for secrets accesspkg/mcp/server/server.go
- Updated tool registrations with schemasUsage Examples
List available secrets
Set a secret from file
Run server with secrets
Testing
Security Considerations
filepath.Clean()
This enhancement allows users to manage ToolHive secrets through the MCP interface and seamlessly pass them to MCP servers, matching the CLI
--secret
flag functionality but accessible through the MCP protocol.