-
Notifications
You must be signed in to change notification settings - Fork 117
MCPRegistry e2e tests #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dmartinol
wants to merge
7
commits into
stacklok:main
Choose a base branch
from
dmartinol:registry_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MCPRegistry e2e tests #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Ginkgo-based test suite for operator testing - Add comprehensive test helpers for MCPRegistry operations - Include test fixtures with sample YAML manifests - Set up Kubernetes test environment with envtest support - Add namespace isolation and cleanup utilities 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
- Create test suite with proper Kubernetes environment setup - Add specialized helper utilities for MCPRegistry operations - Implement ConfigMap test helpers for registry data validation - Add status validation helpers for phase and condition checking - Create timing utilities with proper timeout configurations - Add test data factories for generating test resources - Include builder patterns for fluent resource construction - Support both ToolHive and upstream MCP registry formats - Add comprehensive test fixtures and scenarios 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
- Fix finalizer removal using Patch instead of Update to avoid resource conflicts - Update registry data structure to match expected schema (add required fields: tier, status, tools, image) - Add proper registry deletion waiting in cleanup to prevent namespace deletion issues - Fix lint errors by removing dot imports from non-test files - Add comprehensive MCPRegistry lifecycle test coverage - Improve error handling and logging in test helpers Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> 🤖 Generated with [Claude Code](https://claude.ai/code)
… errors) Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
… correct initial status" Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
- Introduced environment variable handling for KUBEBUILDER_ASSETS - Added warning for missing kubebuilder assets to improve test reliability - Updated test environment configuration to include BinaryAssetsDirectory This change aims to streamline the e2e testing process and provide clearer feedback on asset availability. Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
- initial draft of e2e tests Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 47.91% 47.80% -0.11%
==========================================
Files 233 235 +2
Lines 29172 29273 +101
==========================================
+ Hits 13978 13995 +17
- Misses 14166 14246 +80
- Partials 1028 1032 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First bunch of tests to address #1749
It also depends on #2016 which should be committed first
test/e2e/operator/registry_lifecycle_test.go
initial test to prove the capabilities ofginkgo
as the testing framework for orchestrated workflowsQuestions to be answered:
operator-e2e-test
task?