Drop unused env file field in runconfig

cmd/thv-operator/controllers/mcpserver_runconfig.go

@@ -328,14 +328,10 @@
 		accessor := accessors.NewMCPServerFieldAccessor()
 		_, annotations := accessor.GetProxyDeploymentTemplateLabelsAndAnnotations(m)
 		if len(annotations) > 0 {
 			vaultDetected = hasVaultAgentInjection(annotations)
 		}
 	}
 
-	if vaultDetected {
-		options = append(options, runner.WithEnvFileDir("/vault/secrets"))
-	}
-
 	// Use the RunConfigBuilder for operator context with full builder pattern
 	return runner.NewOperatorRunConfigBuilder(
 		context.Background(),

cmd/thv-operator/controllers/mcpserver_runconfig_test.go

@@ -1906,9 +1906,6 @@ func TestEnsureRunConfigConfigMap_WithVaultInjection(t *testing.T) {
 			err = json.Unmarshal([]byte(configMap.Data["runconfig.json"]), &runConfig)
 			require.NoError(t, err)
 
-			// Verify EnvFileDir is set correctly
-			assert.Equal(t, tc.expectedEnvDir, runConfig.EnvFileDir, "EnvFileDir should match expected value")
-
 			// Verify basic RunConfig fields
 			assert.Equal(t, tc.mcpServer.Name, runConfig.Name)
 			assert.Equal(t, tc.mcpServer.Spec.Image, runConfig.Image)

pkg/runner/config_builder.go

@@ -1001,11 +1001,3 @@ func WithEnvFilesFromDirectory(dirPath string) RunConfigBuilderOption {
 		return nil
 	}
 }
-
-// WithEnvFileDir sets the directory path for loading environment files (for ConfigMap serialization)
-func WithEnvFileDir(dirPath string) RunConfigBuilderOption {
-	return func(b *runConfigBuilder) error {
-		b.config.EnvFileDir = dirPath
-		return nil
-	}
-}

pkg/runner/config_builder_test.go

@@ -879,12 +879,10 @@ func TestWithEnvFileDir(t *testing.T) {
 				mockValidator,
 				WithName("test-server"),
 				WithImage("test-image:latest"),
-				WithEnvFileDir(tc.envFileDir),
 			)
 
 			require.NoError(t, err, "Builder should not fail")
 			require.NotNil(t, config, "Config should not be nil")
-			assert.Equal(t, tc.expectedDir, config.EnvFileDir, "EnvFileDir should match expected value")
 		})
 	}
 }
@@ -897,7 +895,6 @@ func TestRunConfigSerialization_WithEnvFileDir(t *testing.T) {
 		SchemaVersion: CurrentSchemaVersion,
 		Name:          "test-server",
 		Image:         "test-image:latest",
-		EnvFileDir:    "/vault/secrets",
 		EnvVars:       map[string]string{"TEST": "value"},
 	}
 
@@ -916,7 +913,6 @@ func TestRunConfigSerialization_WithEnvFileDir(t *testing.T) {
 	require.NoError(t, err, "Unmarshaling should not fail")
 
 	// Verify EnvFileDir is correctly deserialized
-	assert.Equal(t, "/vault/secrets", deserializedConfig.EnvFileDir, "EnvFileDir should be correctly deserialized")
 	assert.Equal(t, config.Name, deserializedConfig.Name, "Name should be correctly deserialized")
 	assert.Equal(t, config.Image, deserializedConfig.Image, "Image should be correctly deserialized")
 }