-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial sbtc docs update #1647
base: master
Are you sure you want to change the base?
Initial sbtc docs update #1647
Conversation
concepts/sbtc/operations/deposit.md
Outdated
@@ -1,42 +1,25 @@ | |||
# sBTC Deposit Operation | |||
|
|||
The deposit operation allows users to convert their BTC to sBTC. This process involves moving BTC from the Bitcoin blockchain to the Stacks blockchain as sBTC. | |||
The deposit operation enables users to convert their BTC to sBTC, effectively moving value from the Bitcoin blockchain to the Stacks blockchain. This process can be completed within a single Bitcoin block, streamlining the user experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really moving value though? or just adding value?
i think there needs to be some qualifiers about "a single bitcoin block" as well - single block confirmations are inherently dangerous, and bitcoin can and does have forks (meaning a single block confirmation may be reverted).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AshtonStephens where are we with single Bitcoin block confirmations in regards to potential forks? I remember briefly having this conversation with you but can't remember why we said single block confirmations for deposits.
|
||
## User Experience | ||
|
||
From a user's perspective, the deposit process involves: | ||
From a user's perspective, the deposit process is straightforward. Users initiate a BTC transaction to a specified address and then wait for the transaction to be confirmed on the Bitcoin blockchain. Once confirmed, they receive the equivalent amount of sBTC in their Stacks wallet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how many confirmations?
One thing i'm nore sure about is the use of "sortitions" vs using "confirmations". is there a benefit to using one over the other? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenrogers I think we should remove the concept of "Bootstrap Signers" to only be "sBTC Signers." We did this in the SIP for simplicity and to remove the difference between the two systems for both users and developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file just refers to the Clarity contract with that name. @AshtonStephens correct me if I'm wrong, but I don't think this refers to the phase 1 bootstrap signers, this is just the contract that is used whenever the signer set changes, so bootstrap here refers to "bootstrapping" the new signer set.
|
||
sBTC empowers developers to build applications on Bitcoin by bridging Bitcoin and [Stacks](https://www.stacks.co/). We achieve this by introducing a fungible token (sBTC) on the Stacks blockchain. The token has the following properties: | ||
1. **Bitcoin Compatibility**: Allows Bitcoin holders to participate in the Stacks ecosystem without selling their BTC. | ||
2. **DeFi Access**: Enables BTC holders to participate in DeFi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been mentioned a few times now that i've noticed, but i don't see how a "BTC holder" may participate in DeFi. If we're not going to say how someone can do that in this doc, i would reword this. I don't have any suggestions at the moment though.
sBTC empowers developers to build applications on Bitcoin by bridging Bitcoin and [Stacks](https://www.stacks.co/). We achieve this by introducing a fungible token (sBTC) on the Stacks blockchain. The token has the following properties: | ||
1. **Bitcoin Compatibility**: Allows Bitcoin holders to participate in the Stacks ecosystem without selling their BTC. | ||
2. **DeFi Access**: Enables BTC holders to participate in DeFi. | ||
3. **Quick Conversions**: Facilitates rapid movement between BTC and sBTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be quantified? i.e. ... within 5 bitcoin blocks
or whichever is the correct number of blocks
1. **Bitcoin Compatibility**: Allows Bitcoin holders to participate in the Stacks ecosystem without selling their BTC. | ||
2. **DeFi Access**: Enables BTC holders to participate in DeFi. | ||
3. **Quick Conversions**: Facilitates rapid movement between BTC and sBTC. | ||
4. **Decentralized Management**: Utilizes a set of signers for maintaining the peg wallet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would be specific here and mention there will be 15 signers, and possibly link to the SIP defining how those signers shall be chosen (or the working group discussion where the initial signers are listed)
2. **DeFi Access**: Enables BTC holders to participate in DeFi. | ||
3. **Quick Conversions**: Facilitates rapid movement between BTC and sBTC. | ||
4. **Decentralized Management**: Utilizes a set of signers for maintaining the peg wallet. | ||
5. **Community Governance**: Involves the community in key decisions, such as selecting the initial signing set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above - i'm not sure how accurate/informative needs to be, but it feels like these statements are missing context and introduce questions that aren't being answered.
the counter argument is that it's not relevant for the doc, and would just add more text to read through vs being shorter and easier to digest.
Update sBTC docs with new design