Chore - Split reskin (v2) into seperate sub route so v1 can still stand while we push updates to v2 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setbern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this pr is to have V1 bridge live with V2.
This is accomplished by having v2 live in a sub route
/reclaim, v1 lives as normal in/.There should be no UI files being references inside /reclaim to v1 components.
On the other hand as much business logic should be reused in order to prevent duplication of work and possible mistakes.
This pr aims to have both version of the bridge coexist, does not promise all bugs solved on v2 but it should not effect in the slightest v1 bridge. This is extremely important to enforce, If any change to v1 bridge is found please flag asap. From my testing and PR review there seem to be only one major v1 change.
LayoutClienthas custom logic to render v1 or v2 header and footers.