Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design]: Deposit API LLD #50

Closed
10 tasks done
AshtonStephens opened this issue Apr 15, 2024 · 3 comments
Closed
10 tasks done

[Design]: Deposit API LLD #50

AshtonStephens opened this issue Apr 15, 2024 · 3 comments
Assignees
Labels
design making a design decision. emily API that communicates with Signers to trigger sBTC operations.

Comments

@AshtonStephens
Copy link
Collaborator

AshtonStephens commented Apr 15, 2024

Design - Deposit API LLD

Ownership breakdown: #47

This ticket tracks creating the low level design document for the deposit api. For a low level design to be "complete" it must have the approval of the majority of the sBTC team and meet the criteria of the checklist below.

Related Research

Acceptance Criteria Checklist

  • There's a written low level design doc with the following
    • Clear descriptions of all component interactions including serialization format
    • Diagram/s on how the component will work
    • Clear descriptions of the programming languages and infrastructure that will be used
    • Justifications for the design decisions
    • A rough task breakdown of the component's implementation plan referencing inter-dependencies
    • A general list of the of tests required for the component
  • Low level design has been reviewed and approved with the secondary.
  • Low level design has been reviewed and approved with the team.
  • The task breakdown is refined with GitHub issues for each task
@AshtonStephens AshtonStephens added the design making a design decision. label Apr 15, 2024
@AshtonStephens AshtonStephens added the emily API that communicates with Signers to trigger sBTC operations. label Apr 15, 2024
@AshtonStephens
Copy link
Collaborator Author

AshtonStephens commented Apr 17, 2024

@xoloki @setzeus, I'm looking at some updated API queries for the Deposit API. What are our thoughts on this:

Create Deposit Request

Name Datatype Meaning
txid String Bitcoin transaction id
output-index Int Bitcoin transaction output index for the deposit.
deposit-script String The deposit taproot script that pays to the sBTC Bootstrap Signers.
reclaim-script String The reclaim taproot script that allows the depositor to take the Bitcoin they attempted to deposit back.

What other information does the deposit API need to assess whether the deposit-script and the reclaim-script are the full taproot script tree?

@AshtonStephens
Copy link
Collaborator Author

Created and closed this ticket today, where I created a proof of concept local development environment for a lambda-backed CDK-deployed API Gateway instance.

@AshtonStephens
Copy link
Collaborator Author

Closing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design making a design decision. emily API that communicates with Signers to trigger sBTC operations.
Projects
Archived in project
Development

No branches or pull requests

4 participants