Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/android/tts reinit for onstart #411

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix/android/tts reinit for onstart #411

merged 3 commits into from
Jan 7, 2025

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Jan 7, 2025

  • Corrects situation where recommend tts.shutdown() in MainActivity's onDestroy() method results in null val tts: TextToSpeech
  • Adds mockk and turbine to encourage easier android testing.
  • Tests the AndroidTtsObserver.

@Archdoog Archdoog requested a review from ianthetechie January 7, 2025 06:50
ianthetechie
ianthetechie reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor doc fix ;)

guide/src/android-getting-started.md Outdated Show resolved Hide resolved
@ianthetechie ianthetechie merged commit 772d778 into main Jan 7, 2025
12 checks passed
@ianthetechie ianthetechie deleted the fix/android/tts-reinit-for-onstart branch January 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archdoog @ianthetechie