Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(itinerary-list): contains non transit entries #874

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(itinerary-list): contains non transit entries #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/component/ItineraryPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,11 @@ class ItineraryPage extends React.Component {
]),
};

const parkRidePlan = {
...result.parkRidePlan,
itineraries: transitItineraries(result.parkRidePlan.itineraries),
};

this.setState(
{
loadingAlt: false,
Expand All @@ -324,7 +329,7 @@ class ItineraryPage extends React.Component {
scooterRentAndPublicPlan: result.scooterRentAndPublicPlan,
carPlan: result.carPlan,
carRentalPlan: result.carRentalPlan,
parkRidePlan: result.parkRidePlan,
parkRidePlan,
Comment on lines -327 to +332
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason result.parkRidePlan is not needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    const parkRidePlan = {
          ...result.parkRidePlan,
          itineraries: transitItineraries(result.parkRidePlan.itineraries),
        };

result.parkRidePlan is used, I applied a transitItineraries filter a few lines above.

onDemandTaxiPlan: result.onDemandTaxiPlan,
},
() => {
Expand Down
3 changes: 2 additions & 1 deletion app/component/StreetModeSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,10 @@ export const StreetModeSelector = ({
...(bikeParkPlan?.itineraries || []),
...(bikeAndPublicPlan?.itineraries || []),
...(bikeRentAndPublicPlan?.itineraries || []),
],
].filter(itinerary => itinerary.legs.some(l => l.transitLeg)),
}
: {};

const carRentalOrOwn = !loading
? {
itineraries: [
Expand Down
Loading