Add --create-socket flag
#20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics of `--reuse-socket` were confusing; `--create-socket` tries to be more straightforward, a true value indicates that the program is going to do something (which seems more intuitive.) This also should open the door for inferring the value as in stairwell-inc#9 if the flag is not specified (probably by making it an enum type rather than an `Option<bool>`.)
mrdomino
added a commit
that referenced
this pull request
Mar 15, 2025
This integrates #9 and #20 into one PR. We add a `--create-socket` flag, deprecating `--reuse-socket` since the former seems more intuitive. If `--create-socket` is true, then the program will create and manage its own temporary SSH control socket; if it is false, the program will not. If it is unspecified, then the program will try to parse the output of `ssh -G` to decide whether or not to create a socket, specifically looking for a `controlmaster auto` line that would imply that the user is already using their own SSH connection multiplexing. This PR also includes a couple other changes: - We switch to using the `linux-native-sync-persistent` keyring on Linux, in the hopes that this will work with what `aspect-credential-helper` will be using. - Increments the version to 0.4.0. --------- Co-authored-by: Andy Walker <andy@andy.dev>
|
Merged with #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of
--reuse-socketwere confusing;--create-sockettries to be more straightforward, a true value indicates that the program is going to do something (which seems more intuitive.)This also should open the door for inferring the value as in #9 if the flag is not specified (probably by making it an enum type rather than an
Option<bool>and making the default value something likeinfer.)