Resolved: Implement Responsive Impact Section Matching Design Specifications #96#112
Merged
Ayoazeez26 merged 27 commits intostakepoint:stagingfrom Mar 29, 2025
Merged
Conversation
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
Signed-off-by: raremmemshima <ihuwediane@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ayoazeez26
requested changes
Mar 25, 2025
| const Impact = () => { | ||
| return ( | ||
| <div className="flex flex-col max-w-3xl mx-auto gap-5 text-left uppercase"> | ||
| <p className=" text-[#E0FE10] -rotate-2 px-2 font-comedik"> |
Contributor
There was a problem hiding this comment.
Add appropriate font size here
| {countWithText.map(({ count, text }) => ( | ||
| <div key={text} className="flex flex-col text-left"> | ||
| <span className="text-6xl font-bold font-schabo">{count}+</span> | ||
| <span className="flex flex-wrap text-ellipsis w-2/3 font-semibold text-sm"> |
Contributor
There was a problem hiding this comment.
Add letter spacing specified on the design here
Comment on lines
34
to
36
| <p className="text-xl uppercase text-[#E0FE10] -rotate-2 px-2 text-ellipsis max-w-sm font-comedik"> | ||
| you've made it this far, so here's the tl;dr: | ||
| </p> |
Contributor
There was a problem hiding this comment.
This is supposed to look like this
But it looks like this
Please fix
| <p className="text-xl uppercase text-[#E0FE10] -rotate-2 px-2 text-ellipsis max-w-sm font-comedik"> | ||
| you've made it this far, so here's the tl;dr: | ||
| </p> | ||
| <p className="flex flex-wrap w-3/4 lowercase font-medium text-wrap px-2"> |
Contributor
There was a problem hiding this comment.
remove lowercase and add letter spacing specified in the design
| </div> | ||
| </div> | ||
| </div> | ||
| ); |
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
Contributor
Author
|
|
Contributor
This banner should span across the page and not be constrained, think you can do that?
|
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
|
Deployment failed with the following error: |
Contributor
|
@RareMmemshima your build is failing, kindly check |
Signed-off-by: RareMmemshima <Ihuwediane@gmail.com>
Ayoazeez26
approved these changes
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolved issue #96 by Implementing a "responsive impact section" that matched the provided design specifications. It is fully responsive and is consistent with the design.
Type of Change
Checklist
Related Issue
Screenshots (if applicable)