Fix ClientResponseError logging

src/commands/validators_exit.py

@@ -13,7 +13,7 @@
 from web3 import Web3
 
 from src.common.clients import consensus_client
-from src.common.utils import log_verbose
+from src.common.utils import format_error, log_verbose
 from src.common.validators import validate_eth_address
 from src.common.vault_config import VaultConfig
 from src.config.settings import AVAILABLE_NETWORKS, NETWORKS, settings
@@ -199,7 +199,10 @@ async def main(count: int | None) -> None:
             # Validator status is updated in CL after some delay.
             # Status may be active in CL although validator has started exit process.
             # CL will return status 400 for exit request in this case.
-            log_verbose(e)
+            click.secho(
+                f'{format_error(e)} for validator_index {exit_keystore.index}',
+                fg='yellow',
+            )
             continue
 
         exited_indexes.append(exit_keystore.index)

src/common/startup_check.py

@@ -9,6 +9,7 @@
 
 from src.common.clients import db_client
 from src.common.execution import check_hot_wallet_balance, get_oracles
+from src.common.utils import log_verbose
 from src.common.wallet import hot_wallet
 from src.config.settings import settings
 from src.validators.execution import check_deposit_data_root
@@ -118,7 +119,7 @@ async def collect_healthy_oracles() -> list:
     healthy_oracles = []
     for result in results:
         if isinstance(result, Exception):
-            logger.error(repr(result))
+            log_verbose(result)
             continue
 
         if result:

src/common/utils.py

@@ -5,6 +5,7 @@
 from datetime import datetime, timezone
 from pathlib import Path
 
+import aiohttp
 from eth_typing import BlockNumber, ChecksumAddress
 from web3 import Web3
 from web3.types import Timestamp, Wei
@@ -41,7 +42,20 @@ def log_verbose(e: Exception):
     if settings.verbose:
         logger.exception(e)
     else:
-        logger.error(repr(e))
+        logger.error(format_error(e))
+
+
+def format_error(e: Exception) -> str:
+    if isinstance(e, aiohttp.ClientResponseError):
+        # repr(e) gives too much output
+        return (
+            f'ClientResponseError('
+            f'status={e.status}, '
+            f'message="{e.message}", '
+            f'url="{e.request_info.url}")'
+        )
+
+    return repr(e)
 
 
 async def wait_block_finalization(block_number: BlockNumber | None = None):

src/exits/utils.py

@@ -11,7 +11,7 @@
 from web3 import Web3
 
 from src.common.typings import OracleApproval, Oracles, OraclesApproval
-from src.common.utils import process_oracles_approvals
+from src.common.utils import log_verbose, process_oracles_approvals
 from src.config.settings import (
     DEFAULT_RETRY_TIME,
     OUTDATED_SIGNATURES_URL_PATH,
@@ -39,7 +39,7 @@ async def send_signature_rotation_requests(
                     session=session, replicas=replicas, payload=payload
                 )
             except Exception as e:
-                logger.error(repr(e))
+                log_verbose(e)
                 continue
             approvals[address] = response
 
@@ -60,7 +60,7 @@ async def send_signature_rotation_request_to_replicas(
         try:
             return await send_signature_rotation_request(session, endpoint, payload)
         except (ClientError, asyncio.TimeoutError) as e:
-            logger.debug('%s for %s', repr(e), endpoint)
+            log_verbose(e)
             last_error = e
 
     if last_error:

src/validators/utils.py

@@ -20,7 +20,7 @@
 
 from src.common.contracts import validators_registry_contract
 from src.common.typings import OracleApproval, Oracles, OraclesApproval
-from src.common.utils import process_oracles_approvals
+from src.common.utils import format_error, process_oracles_approvals
 from src.config.settings import DEFAULT_RETRY_TIME, ORACLES_VALIDATORS_TIMEOUT, settings
 from src.validators.database import NetworkValidatorCrud
 from src.validators.exceptions import (
@@ -61,7 +61,9 @@ async def send_approval_requests(oracles: Oracles, request: ApprovalRequest) ->
     approvals: dict[ChecksumAddress, OracleApproval] = {}
     for address, result in zip(oracles.addresses, results):
         if isinstance(result, Exception):
-            logger.error(repr(result))
+            logger.error(
+                'All endpoints failed for oracle %s. Last error: %s', address, format_error(result)
+            )
             continue
 
         approvals[address] = result
@@ -83,7 +85,7 @@ async def send_approval_request_to_replicas(
         try:
             return await send_approval_request(session, endpoint, payload)
         except (ClientError, asyncio.TimeoutError) as e:
-            logger.debug('%s for %s', repr(e), endpoint)
+            logger.warning('%s for endpoint %s', format_error(e), endpoint)
             last_error = e
 
     if last_error: