Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add sign in confirmation modal + reword show review limit alert #77

Merged
merged 4 commits into from
May 17, 2024

Conversation

chinathaip
Copy link
Contributor

@chinathaip chinathaip commented May 15, 2024

  • Notify users to sign out if their account is not stamford student (This is a very safe temporary solution - the review page is very critical and changes should be carefully tested in beta server before deployment which we can't do it yet....)
  • Force refresh when sign out to clear all the sessions and prevent from being able to do things you shouldn't (e.g. see their "My reviews" after signing out)
  • This modal will appear when clicking on the sign in button in both header and navbar

image

@chinathaip chinathaip requested review from Lxkas, CryoMilo and NayHtetKyaw and removed request for Lxkas and CryoMilo May 15, 2024 14:31
@chinathaip chinathaip marked this pull request as ready for review May 15, 2024 14:32
Copy link
Contributor

@NayHtetKyaw NayHtetKyaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@chinathaip chinathaip merged commit 394cf19 into main May 17, 2024
1 check passed
@chinathaip chinathaip deleted the khing/frontend/ui-improvement branch May 17, 2024 10:22
@chinathaip chinathaip linked an issue May 19, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONTEND] UX/UI Improvement
2 participants