backend: add term and section for submitting and editing review #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04cb1a7.
chinathaip
force-pushed
the
khing/add-term-sec
branch
from
f538ef2 to
38ff4b7
Compare
This reverts commit 35c385b.
Lxkas
reviewed
Jun 30, 2024
Comment on lines
129
to
135
| if err := isTermValid(review); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := isSectionValid(review); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Where is the GetBoolEnv and feature flag for this XD
There was a problem hiding this comment.
OH SHOOT GOOD CATCH
|
so we are specifying term and section now |
yeah, I think it should allow the university to use this information for improving the course experience. Also, got a green light from the acting president himself to add this XD |
Lxkas
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_TERM_SECTION_VALIDATIONenv is set totrue