feat: add fish shell support for prompt bootstrap#49
Open
jsseoi wants to merge 1 commit intostandardagents:mainfrom
Open
feat: add fish shell support for prompt bootstrap#49jsseoi wants to merge 1 commit intostandardagents:mainfrom
jsseoi wants to merge 1 commit intostandardagents:mainfrom
Conversation
Use fish-compatible `set VAR value` syntax instead of `VAR=value` when the user's shell is fish. Requires fish 3.4+ for `$()` support. Relates to standardagents#31 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildPromptReadAndDeleteSnippetso prompt bootstrap usesset VAR valueinstead ofVAR=valuewhen the user's shell is fish$()command substitution supportContext
Fish shell does not support
VAR=valuestandalone assignment syntax. The existingbuildPromptReadAndDeleteSnippetgenerates a shell snippet sent to tmux panes viasend-keys. When the pane runs fish, theVAR=valuesyntax fails silently, causing the agent to launch without a prompt.Other shell constructs used by dmux (
&&,||,$(),2>/dev/null) are supported in fish 3.0+/3.4+, so only the variable assignment syntax needed a fish-specific code path.Relates to #31
Test plan
pnpm run typecheckpassespnpm run testpasses (4 pre-existing failures unrelated to this change)🤖 Generated with Claude Code