Fix wikidata starter test

stanford-oval · Oct 11, 2021 · b5a0256 · b5a0256
1 parent 8949a89
commit b5a0256
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/starter/wikidata/Makefile b/starter/wikidata/Makefile
@@ -61,6 +61,8 @@ maxdepth ?= 8
 fewshot =
 fewshot_size = 100
 
+train_batch_tokens = 2000
+val_batch_size = 4000
 
 # options for training
 model ?= 1
@@ -74,8 +76,8 @@ train_nlu_flags ?= \
 	--warmup 20 \
 	--gradient_accumulation_steps 20 \
 	--eval_set_name valid \
-	--train_batch_tokens 2000 \
-	--val_batch_size 4000 \
+	--train_batch_tokens $(train_batch_tokens) \
+	--val_batch_size $(val_batch_size) \
 	--preprocess_special_tokens \
 	--override_question= 
 custom_train_nlu_flags ?=
@@ -271,6 +273,7 @@ train: $(datadir)
 	-rm datadir/almond
 	ln -sf . datadir/almond
 	genienlp train \
+	  --no_commit \
 	  --data $(datadir) \
 	  --save $(experiment)/models/$(model) \
 	  --cache $(datadir)/.cache \

diff --git a/test/wikidata-starter.sh b/test/wikidata-starter.sh
@@ -29,7 +29,7 @@ wget --no-verbose https://almond-static.stanford.edu/research/csqa/kb-small/item
 
 # generate & train
 touch domains.tsv bootleg-types.json bootleg-type-canonicals.json
-starter_gen_and_train wikidata city annotation=baseline wikidata_dir=raw/wikidata-small 
+starter_gen_and_train wikidata city annotation=baseline wikidata_dir=raw/wikidata-small train_batch_tokens=100 val_batch_size=500
 
 # evaluate
 make experiment=city model=small evaluate