Ud2 updates #1445
Merged
Ud2 updates #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngledLuffa
force-pushed
the
ud2_updates
branch
2 times, most recently
from
49c941a to
fbe62ad
Compare
AngledLuffa
force-pushed
the
ud2_updates
branch
3 times, most recently
from
9e56520 to
074724f
Compare
AngledLuffa
force-pushed
the
ud2_updates
branch
from
b1ef8ab to
c463f96
Compare
…the resulting dependencies both connect to day instead of from about -> a, changing the UD nummod to a det
…ut changing TreeGraphNode to print out the whole tree, but that would presumably mess up some various dependency outputs
…ke sure the XPOS tags get updated in the converter when using the PTB corrector
…ted trees for the structure of the UD graphs, not just the tags. Noticeably reduces the number of validator errors
gripes and complains both show up in PTB in terms of checking the results. most of the other verbs added do not
actually, there's only one in PTB - Also excluded will be investments ...
…hat random hash ordering doesn't cause the graph to have a different output
AngledLuffa
force-pushed
the
ud2_updates
branch
from
c463f96 to
1535cab
Compare
… from the CONJP (sometimes ADVP by error) that they show up in. This allows the later part of the converter to connect both of them to the parent with advmod. As part of this, turn the UPOS of "not" into PART Also, update the corrector to make a few changes to the structure, which may help usages of the trees or of SD as well as the UD. The UD changes are written to accommodate the structural errors in the original PTB, though
AngledLuffa
force-pushed
the
ud2_updates
branch
from
7b095f4 to
a2de460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to better match the new dependency scheme for list items, as done in UD2.14
Put the PTB Corrector earlier in the dependency conversion, making better use of its changes