Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English corrections #210

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Lolabird
Copy link
Contributor

@Lolabird Lolabird commented Oct 15, 2024

These are just small corrections to the English translation. Please feel free to make edits to any of the wording I changed.

There were some others that I wanted to fix just because they sounded a bit awkward to me (in the going section), but they are technically correct, so I left those as they were in the original. Let me know if you would like a pull request for those as well.

@Lolabird Lolabird marked this pull request as draft October 16, 2024 03:15
@Lolabird Lolabird changed the title English corrections Add English corrections Oct 16, 2024
Copy link
Collaborator

@xyloflake xyloflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going good @Lolabird!

Impressive work pointing out the mistakes and most of them look fine however the following need a little attention.

Thank you for your significant contribution in advance 😄

src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
"muffon is a non-profit project that has neither ads nor any paid features or content.",
"But of course, muffon cannot exist without the funds needed for its development and infrastructure.",
"A lot of time and effort were put into creating this project. It would be great if all that investment paid off.",
"As such, I would like to ask for your help in supporting muffon.",
"<strong>Would you like to make a donation?</strong>"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe changing this to "Please consider making a donation." would sound better. @staniel359 please confirm.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyloflake There are buttons after that question, that kind of answer it.
If it'd be a statement, buttons would seem off.

@Lolabird
Copy link
Contributor Author

@xyloflake thanks for making the suggestions! I'll take a look and make adjustments and ask questions if I have any.

@Lolabird
Copy link
Contributor Author

@xyloflake Made all the changes except the one we're waiting for feedback on. Let me know when you'd like me to pull this out of draft status.

@xyloflake
Copy link
Collaborator

xyloflake commented Oct 16, 2024

@xyloflake Made all the changes except the one we're waiting for feedback on.

Seems good @Lolabird, thank you for the amazing compliance 😄

We'll go ahead and wait for @staniel359 to respond.

Let me know when you'd like me to pull this out of draft status.

Well, I would like you to decide when you want us to thoroughly review it and at the very end, when you have no changes to make anymore, you can pull this out of draft 😄

"account": [
"This will also delete your following data:",
"<strong>- library\n- recommendations\n- playlists\n- favorites\n- bookmarks\n- listened\n- your page posts\n- subscriptions\n- history</strong>",
"This will also delete the following data:",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lolabird Maybe "the following data of yours" would be better.

"This data will remain, but your nickname won't be displayed:",
"<strong>- created posts\n- created comments\n- conversations with you\n- created communities</strong>",
"And this data will remain unchanged:",
"<strong>- saved tracks\n- background images\n- settings</strong>"
],
"library": [
"This will delete your following data:",
"This will delete the following data:",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lolabird Same as above.

@@ -520,7 +520,7 @@
"timezone": "Time zone",
"infiniteScroll": "Infinite scroll",
"artistPopup": "Show artist info on link hover",
"innerCounters": "Show muffon listeners counters",
"innerCounters": "Show muffon listeners counter",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lolabird It was intended to be plural.

"So I ask for your help in muffon support.",
"muffon is a non-profit project that has neither ads nor any paid features or content.",
"However, muffon cannot exist without the funds needed for its development and infrastructure.",
"As lot of time and effort were put into creating this project, it would be great to see that investment pay off.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lolabird "As a lot" maybe?

"muffon is a non-profit project that has neither ads nor any paid features or content.",
"But of course, muffon cannot exist without the funds needed for its development and infrastructure.",
"A lot of time and effort were put into creating this project. It would be great if all that investment paid off.",
"As such, I would like to ask for your help in supporting muffon.",
"<strong>Would you like to make a donation?</strong>"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyloflake There are buttons after that question, that kind of answer it.
If it'd be a statement, buttons would seem off.

@staniel359 staniel359 marked this pull request as ready for review February 7, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants