-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add English corrections #210
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going good @Lolabird!
Impressive work pointing out the mistakes and most of them look fine however the following need a little attention.
Thank you for your significant contribution in advance 😄
"muffon is a non-profit project that has neither ads nor any paid features or content.", | ||
"But of course, muffon cannot exist without the funds needed for its development and infrastructure.", | ||
"A lot of time and effort were put into creating this project. It would be great if all that investment paid off.", | ||
"As such, I would like to ask for your help in supporting muffon.", | ||
"<strong>Would you like to make a donation?</strong>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also believe changing this to "Please consider making a donation." would sound better. @staniel359 please confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xyloflake There are buttons after that question, that kind of answer it.
If it'd be a statement, buttons would seem off.
@xyloflake thanks for making the suggestions! I'll take a look and make adjustments and ask questions if I have any. |
@xyloflake Made all the changes except the one we're waiting for feedback on. Let me know when you'd like me to pull this out of draft status. |
Seems good @Lolabird, thank you for the amazing compliance 😄 We'll go ahead and wait for @staniel359 to respond.
Well, I would like you to decide when you want us to thoroughly review it and at the very end, when you have no changes to make anymore, you can pull this out of draft 😄 |
"account": [ | ||
"This will also delete your following data:", | ||
"<strong>- library\n- recommendations\n- playlists\n- favorites\n- bookmarks\n- listened\n- your page posts\n- subscriptions\n- history</strong>", | ||
"This will also delete the following data:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lolabird Maybe "the following data of yours" would be better.
"This data will remain, but your nickname won't be displayed:", | ||
"<strong>- created posts\n- created comments\n- conversations with you\n- created communities</strong>", | ||
"And this data will remain unchanged:", | ||
"<strong>- saved tracks\n- background images\n- settings</strong>" | ||
], | ||
"library": [ | ||
"This will delete your following data:", | ||
"This will delete the following data:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lolabird Same as above.
@@ -520,7 +520,7 @@ | |||
"timezone": "Time zone", | |||
"infiniteScroll": "Infinite scroll", | |||
"artistPopup": "Show artist info on link hover", | |||
"innerCounters": "Show muffon listeners counters", | |||
"innerCounters": "Show muffon listeners counter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lolabird It was intended to be plural.
"So I ask for your help in muffon support.", | ||
"muffon is a non-profit project that has neither ads nor any paid features or content.", | ||
"However, muffon cannot exist without the funds needed for its development and infrastructure.", | ||
"As lot of time and effort were put into creating this project, it would be great to see that investment pay off.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lolabird "As a lot" maybe?
"muffon is a non-profit project that has neither ads nor any paid features or content.", | ||
"But of course, muffon cannot exist without the funds needed for its development and infrastructure.", | ||
"A lot of time and effort were put into creating this project. It would be great if all that investment paid off.", | ||
"As such, I would like to ask for your help in supporting muffon.", | ||
"<strong>Would you like to make a donation?</strong>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xyloflake There are buttons after that question, that kind of answer it.
If it'd be a statement, buttons would seem off.
These are just small corrections to the English translation. Please feel free to make edits to any of the wording I changed.
There were some others that I wanted to fix just because they sounded a bit awkward to me (in the
going
section), but they are technically correct, so I left those as they were in the original. Let me know if you would like a pull request for those as well.