Skip to content

SFW-369 Removed BasePresenter + refactoring #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lucaangeletti wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SFW-369 Removed BasePresenter + refactoring #65

lucaangeletti wants to merge 3 commits into from

Conversation

@lucaangeletti
Copy link
Contributor

@lucaangeletti lucaangeletti commented Jul 15, 2019 •
edited
Loading

What has changed

  1. The Presenter is now dealing (again) with ModuleViewable instead of ModuleViewController
  2. Removed BasePresenter
  3. Minor adjustments

@lucaangeletti lucaangeletti requested a review from talezion July 15, 2019 15:38
@lucaangeletti
Update CHANGELOG.md
97efddc 
Removed `BasePresenter` from changelog
talezion
talezion suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@talezion talezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parking this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@talezion talezion talezion requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucaangeletti @talezion @aaronTredrea