Merge pull request #4 from stape-io/fix-params-override

fix params override
stape-io · Apr 25, 2024 · 9b74395 · 9b74395
2 parents 3069153 + 9b3c7af
commit 9b74395
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/metadata.yaml b/metadata.yaml
@@ -1,5 +1,7 @@
 homepage: 'https://stape.io/'
 versions:
+  - sha: 2db0e8ac59cabe856fba360ad41916c8dd2ffee9
+    changeNotes: Fix params override.
   - sha: 56deec2a17a7f145c28481b58a23a1133b0af255
     changeNotes: Fix optimistic scenario.
   - sha: b50adc0aa8f18a3995a2a6bae17601c6299bccdb

diff --git a/template.js b/template.js
@@ -25,7 +25,7 @@ const params = getMatomoParams(eventNameData);
 
 if (data.parametersToOverride && data.parametersToOverride.length) {
   data.parametersToOverride.forEach((param) => {
-    if (isValidParam(params[param.name])) {
+    if (isValidParam(param.value)) {
       params[param.name] = param.value;
     }
   });

diff --git a/template.tpl b/template.tpl
@@ -275,7 +275,7 @@ const params = getMatomoParams(eventNameData);
 
 if (data.parametersToOverride && data.parametersToOverride.length) {
   data.parametersToOverride.forEach((param) => {
-    if (isValidParam(params[param.name])) {
+    if (isValidParam(param.value)) {
       params[param.name] = param.value;
     }
   });