apollo_storage: separate events from TransactionOutput#13462
Open
MohammadNassar1 wants to merge 2 commits intomohammad/apollo-storage/events-tablefrom
Open
apollo_storage: separate events from TransactionOutput#13462MohammadNassar1 wants to merge 2 commits intomohammad/apollo-storage/events-tablefrom
MohammadNassar1 wants to merge 2 commits intomohammad/apollo-storage/events-tablefrom
Conversation
Events are now written to a dedicated transaction_events table in addition to the events index table. Event iterators read from the new table instead of deserializing transaction outputs from mmap files. This eliminates redundant file I/O during event iteration and prepares for separating events from TransactionOutput in a follow-up change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This change is |
|
Artifacts upload workflows: |
MohammadNassar1
force-pushed
the
mohammad/apollo-storage/events-table
branch
3 times, most recently
from
43aefd3 to
2f4f67d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventsfield from allTransactionOutputvariant structstransaction_events: Vec<Vec<Event>>toBlockBodyappend_eventsandrevert_eventsmethods toBodyStorageWriterappend_bodyintoappend_eventsStacked on #13461
Test plan
apollo_storagetests pass🤖 Generated with Claude Code
Note
Medium Risk
Touches core storage write/revert paths and multiple sync/RPC call sites to persist and fetch events separately; bugs could cause missing events or marker inconsistencies during sync or reorgs.
Overview
Separates transaction events from receipts/
TransactionOutputby addingtransaction_eventstostarknet_api::BlockBodyand removing per-varianteventsfields.Updates
apollo_storageto write and revert events via newBodyStorageWriter::append_events/revert_eventsmethods (with independent event markers and atransaction_eventstable), and updates central sync, p2p sync, RPC receipt construction, state sync, and tests to call these APIs and read events from storage instead ofTransactionOutput.Written by Cursor Bugbot for commit b1883b1. This will update automatically on new commits. Configure here.