-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(starknet_consensus_orchestrator): comment out failing block info validation #4147
fix(starknet_consensus_orchestrator): comment out failing block info validation #4147
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)
crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs
line 851 at r1 (raw file):
) -> bool { let now: u64 = chrono::Utc::now().timestamp().try_into().expect("Failed to convert timestamp to u64");
@asmaastarkware - move this into BlockInfoValidation. Will make debug prints better.
https://reviewable.io/reviews/starkware-libs/sequencer/4148#-
Code quote:
let now: u64 =
chrono::Utc::now().timestamp().try_into().expect("Failed to convert timestamp to u64");
4dcc6b3
to
dc694de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @asmaastarkware)
dc694de
to
99dcbc7
Compare
No description provided.