Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starknet_consensus_orchestrator): comment out failing block info validation #4147

Conversation

alonh5
Copy link
Collaborator

@alonh5 alonh5 commented Feb 13, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)


crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 851 at r1 (raw file):

) -> bool {
    let now: u64 =
        chrono::Utc::now().timestamp().try_into().expect("Failed to convert timestamp to u64");

@asmaastarkware - move this into BlockInfoValidation. Will make debug prints better.

https://reviewable.io/reviews/starkware-libs/sequencer/4148#-

Code quote:

    let now: u64 =
        chrono::Utc::now().timestamp().try_into().expect("Failed to convert timestamp to u64");

@alonh5 alonh5 force-pushed the 02-13-fix_starknet_consensus_orchestrator_comment_out_failing_block_info_validation branch 2 times, most recently from 4dcc6b3 to dc694de Compare February 13, 2025 15:30
@alonh5 alonh5 changed the base branch from 02-13-fix_starknet_integration_tests_check_node_0_metrics to main February 13, 2025 15:30
Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @asmaastarkware)

@alonh5 alonh5 force-pushed the 02-13-fix_starknet_consensus_orchestrator_comment_out_failing_block_info_validation branch from dc694de to 99dcbc7 Compare February 13, 2025 16:44
@alonh5 alonh5 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 615d80e Feb 13, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants