chore(starknet_l1_provider_types): add invalid validation status enum

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(starknet_l1_provider_types): add invalid validation status enum #4256 👈 (View in Graphite)
• chore(starknet_batcher): fix error message on transaction provider error on l1 validation #4187 : 1 other dependent PR (#4210 )
• chore(starknet_l1_provider_types): fix typo in validation status #4186
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

crates/starknet_l1_provider_types/src/lib.rs line 40 at r1 (raw file):

    pub const ConsumedOnL1OrUnknown: Self =
        Self::Invalid(InvalidValidationStatus::ConsumedOnL1OrUnknown);
}

This is cute. I am not sure it is a good design.

Code quote:

impl ValidationStatus {
    #[allow(non_upper_case_globals)]
    pub const AlreadyIncludedInProposedBlock: Self =
        Self::Invalid(InvalidValidationStatus::AlreadyIncludedInProposedBlock);
    #[allow(non_upper_case_globals)]
    pub const AlreadyIncludedOnL2: Self =
        Self::Invalid(InvalidValidationStatus::AlreadyIncludedOnL2);
    #[allow(non_upper_case_globals)]
    pub const ConsumedOnL1OrUnknown: Self =
        Self::Invalid(InvalidValidationStatus::ConsumedOnL1OrUnknown);
}

[alonh5]

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @giladchase)

---

crates/starknet_l1_provider_types/src/lib.rs line 40 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This is cute. I am not sure it is a good design.

Talked f2f, let's opt for readability and conventions.

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @giladchase)

---

crates/starknet_l1_provider_types/src/lib.rs line 40 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Talked f2f, let's opt for readability and conventions.

Done.

[alonh5]

Reviewed 2 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)