Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_mempool): add mempool config to sequencer node #4261

Open
wants to merge 1 commit into
base: mempool-config-definition
Choose a base branch
from

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dafnamatsry commented Feb 19, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dafnamatsry dafnamatsry force-pushed the mempool-config-definition branch from a9ee919 to 91e4746 Compare February 19, 2025 10:58
@dafnamatsry dafnamatsry force-pushed the add-mempool-config-to-node branch 2 times, most recently from 3130a7c to 333bb78 Compare February 19, 2025 11:22
@dafnamatsry dafnamatsry force-pushed the add-mempool-config-to-node branch from 333bb78 to 258c759 Compare February 19, 2025 11:46
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)


config/sequencer/default_config.json line 1467 at r1 (raw file):

    "value": 1000000
  }
}

restore blank line below.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry)

@dafnamatsry dafnamatsry force-pushed the mempool-config-definition branch from 91e4746 to 9375274 Compare February 20, 2025 12:52
@dafnamatsry dafnamatsry force-pushed the add-mempool-config-to-node branch from 258c759 to a6f5a92 Compare February 20, 2025 12:52
@dafnamatsry dafnamatsry force-pushed the add-mempool-config-to-node branch from a6f5a92 to 439beb6 Compare February 20, 2025 13:03
Copy link
Collaborator Author

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @alonh5 and @yair-starkware)


config/sequencer/default_config.json line 1467 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

restore blank line below.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants