feat(starknet_batcher): integrate Papyrus state with class manager to Batcher #4314
Conversation
|
This change is |
|
Artifacts upload workflows: |
elintul
force-pushed
the
elin/class-manager/call-runtime-block-on-in-papyrus-state
branch
3 times, most recently
from
aa18917 to
e07189e
Compare
… Batcher By doing this, `cairo-native` is reenabled.
elintul
force-pushed
the
elin/class-manager/call-runtime-block-on-in-papyrus-state
branch
from
e07189e to
c660a03
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @giladchase and @yair-starkware)
crates/starknet_batcher/Cargo.toml line 21 at r1 (raw file):
papyrus_storage.workspace = true serde.workspace = true starknet-types-core.workspace = true
cargo-machete asked me for some reason.
Code quote:
starknet-types-core.workspace = true
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @giladchase)
crates/papyrus_state_reader/src/papyrus_state.rs line 91 at r1 (raw file):
latest_block: BlockNumber, contract_class_manager: ContractClassManager, class_reader: Option<ClassReader>,
Why is the class reader an option?
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @giladchase and @yair-starkware)
crates/papyrus_state_reader/src/papyrus_state.rs line 91 at r1 (raw file):
Previously, yair-starkware (Yair) wrote…
Why is the class reader an option?
Good Q.
It's None in native_blockifier; there's a comment above.
Reason for this inelegant solution is that this reader is used in both native_blockifier and new Batcher, and in native_blockifier I can't clone any mdbx resources, since it can easily cause a leak when moving from Rust to Python.
Another option was to duplicate this reader, but I chose this easier faster solution.
I have a task on Monday to remove this Option once native_blockifier is deprecated.
By doing this,
cairo-nativeis reenabled.