refactor: share the chain info as a config for the gateway

[ArniStarkware]

The ChainInfo is a part of the config that is relevant not only to the stateful validator but also to the conversion RpcTransaction -> ExecutableTransaction. In this PR we move this config to be a part of the GatewayConfig.

This change is 

[ArniStarkware]

• refactor: share the chain info as a config for the gateway #520 👈
• refactor: refactor the stateful tx validator to get executable tx as input #519 : 3 other dependent PRs (#521 , #604 , #789 )
• chore: create executable tx creator for testing #672
• chore: move chain_id create for testing to snapi test utils #666 : 2 other dependent PRs (#694 , #701 )
• chore: move transaction creator test util to starknet api #661
• chore: split the inner tx creator in blockifier test utils #660
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.02%. Comparing base (b0cfe82) to head (0a62877).
Report is 269 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/gateway/src/config.rs	0.00%	3 Missing ⚠️
crates/gateway/src/gateway.rs	71.42%	0 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (0a62877). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (0a62877)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #520       +/-   ##
===========================================
- Coverage   74.18%   28.02%   -46.16%     
===========================================
  Files         359      205      -154     
  Lines       36240    22162    -14078     
  Branches    36240    22162    -14078     
===========================================
- Hits        26886     6212    -20674     
- Misses       7220    15280     +8060     
+ Partials     2134      670     -1464     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yael-Starkware]

Reviewed 2 of 6 files at r3, all commit messages.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @MohammadNassar1)

---

crates/gateway/src/stateful_transaction_validator_test.rs line 58 at r3 (raw file):

            validate_max_n_steps: block_context.versioned_constants().validate_max_n_steps,
            max_recursion_depth: block_context.versioned_constants().max_recursion_depth,
        },

Suggestion:

        config: StatefulTransactionValidatorConfig::default()

---

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):

            validate_max_n_steps: block_context.versioned_constants().validate_max_n_steps,
            max_recursion_depth: block_context.versioned_constants().max_recursion_depth,
        },

check if can use the fixture here

Suggestion:

        config: StatefulTransactionValidatorConfig::default()

[ArniStarkware]

Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @MohammadNassar1 and @Yael-Starkware)

---

crates/gateway/src/stateful_transaction_validator_test.rs line 58 at r3 (raw file):

            validate_max_n_steps: block_context.versioned_constants().validate_max_n_steps,
            max_recursion_depth: block_context.versioned_constants().max_recursion_depth,
        },

Done.

---

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

check if can use the fixture here

Done.

[Yael-Starkware]

Reviewed 1 of 7 files at r2, 1 of 6 files at r3, 4 of 5 files at r4, all commit messages.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @MohammadNassar1)

---

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Done.

so the fixture didn't work?

[ArniStarkware]

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

so the fixture didn't work?

It did. stateful_validator was removed.

[ArniStarkware]

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

It did. stateful_validator was removed.

stateful validator is now a fixture of the test.
There is no need for chain_info to be a fixture - as this is the only test where it is used.

[Yael-Starkware]

Reviewed 1 of 5 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

[Yael-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)