Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize 0.6.0 - remove rc from version #162

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Stabilize 0.6.0 - remove rc from version #162

merged 2 commits into from
Dec 11, 2023

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Dec 11, 2023

This change is Reviewable

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major: blocking to remind myself to full-merge instead of merge-queue/squash/rebase

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @elintul and @Yoni-Starkware)

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @elintul and @Yoni-Starkware)


-- commits line 1 at r1:
Blocking to remind myself to merge.

@giladchase giladchase requested a review from liorgold2 December 11, 2023 15:36
Copy link

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @Yoni-Starkware)

Copy link

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @Yoni-Starkware)

@giladchase giladchase merged commit ef97dee into main Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants